[ 
https://issues.apache.org/jira/browse/HDFS-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964229#comment-14964229
 ] 

Colin Patrick McCabe commented on HDFS-9252:
--------------------------------------------

bq. The data length and genstemp read from disk are the expected values here, 
and the in-memory {{ExternedBlock}}s are the actual value. It is also 
consistent with the above data length tests.

OK.

Thanks for fixing the other stuff.  +1

> Change TestFileTruncate to use FsDatasetTestUtils to get block file size and 
> genstamp.
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-9252
>                 URL: https://issues.apache.org/jira/browse/HDFS-9252
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.7.1
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HDFS-9252.00.patch, HDFS-9252.01.patch
>
>
> {{TestFileTruncate}} verifies block size and genstamp by directly accessing 
> the  local filesystem, e.g.:
> {code}
> assertTrue(cluster.getBlockMetadataFile(dn0,
>    newBlock.getBlock()).getName().endsWith(
>    newBlock.getBlock().getGenerationStamp() + ".meta"));
> {code}
> Lets abstract the fsdataset-special logic behind FsDatasetTestUtils.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to