[ https://issues.apache.org/jira/browse/HDFS-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965773#comment-14965773 ]
Hudson commented on HDFS-9251: ------------------------------ FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #518 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/518/]) HDFS-9251. Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java > Refactor TestWriteToReplica and TestFsDatasetImpl to avoid explicitly > creating Files in tests code. > --------------------------------------------------------------------------------------------------- > > Key: HDFS-9251 > URL: https://issues.apache.org/jira/browse/HDFS-9251 > Project: Hadoop HDFS > Issue Type: Improvement > Components: HDFS > Affects Versions: 2.7.1 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Fix For: 3.0.0, 2.8.0 > > Attachments: HDFS-9251.00.patch, HDFS-9251.01.patch, > HDFS-9251.02.patch > > > In {{TestWriteToReplica}} and {{TestFsDatasetImpl}}, tests directly creates > block and metadata files: > {code} > replicaInfo.getBlockFile().createNewFile(); > replicaInfo.getMetaFile().createNewFile(); > {code} > It leaks the implementation details of {{FsDatasetImpl}}. This JIRA proposes > to use {{FsDatasetImplTestUtils}} (HDFS-9188) to create replicas. -- This message was sent by Atlassian JIRA (v6.3.4#6332)