[
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967515#comment-14967515
]
Haohui Mai commented on HDFS-8766:
----------------------------------
Thanks for the comments, Bob.
bq. I'm unsure if you see all of them as show-stoppers and some as small nits;
it would be nice if you could clarify that when we have the narrow band of Jira
to communicate.
The earlier comments are fairly mechanical. They usually come from Jenkins if
Jenkins is working. We have strong emphasis to minimize code duplication,
consistent coding styles to allow other people in the community to participate.
I see the above comments as the low bars before the patch is ready to be
reviewed.
For 1a and 1b, please refer to HDFS-9253.
bq. As we discussed, we will be losing a valuable debugging aid that has sussed
out issues in integration testing already. I don't think we should ship with
this in-place, but I would like to keep it for the short term. Again, let's
make a "Before we merge with trunk" Jira to capture that so we can both reap
the benefits of it during the high-risk portion of our development and not
merge it into trunk.
While dev branches are usually fast moving, we have the same level of
expectations on quality controls. We also try to maintain a very clear commit
history so that it is easy to merge to code back to trunk. That is being said,
it's very undesirable to commit macros and debugging codes into the repository.
However, the git workflows should allow you to keep these codes locally and to
be applied when they are required.
We also have strong emphasis keep patches small and independent so that they
can be easily reviewed and committed. They will allow faster development in the
dev branch.
> Implement a libhdfs(3) compatible API
> -------------------------------------
>
> Key: HDFS-8766
> URL: https://issues.apache.org/jira/browse/HDFS-8766
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: James Clampffer
> Assignee: James Clampffer
> Attachments: HDFS-8766.HDFS-8707.000.patch,
> HDFS-8766.HDFS-8707.001.patch, HDFS-8766.HDFS-8707.002.patch,
> HDFS-8766.HDFS-8707.003.patch, HDFS-8766.HDFS-8707.004.patch,
> HDFS-8766.HDFS-8707.005.patch, HDFS-8766.HDFS-8707.006.patch,
> HDFS-8766.HDFS-8707.007.patch
>
>
> Add a synchronous API that is compatible with the hdfs.h header used in
> libhdfs and libhdfs3. This will make it possible for projects using
> libhdfs/libhdfs3 to relink against libhdfspp with minimal changes.
> This also provides a pure C interface that can be linked against projects
> that aren't built in C++11 mode for various reasons but use the same
> compiler. It also allows many other programming languages to access
> libhdfspp through builtin FFI interfaces.
> The libhdfs API is very similar to the posix file API which makes it easier
> for programs built using posix filesystem calls to be modified to access HDFS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
