[
https://issues.apache.org/jira/browse/HDFS-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970118#comment-14970118
]
Yongjun Zhang commented on HDFS-7284:
-------------------------------------
Thanks [~huLiu] for reporting the issue and [~jojochuang] for the patch. I
think this is a good supportability jira.
Hi [~jojochuang],
I think we can change the message to:
{code}
NameNode.blockStateChangeLog.debug("BLOCK* Removing stale replica "
+ r + " of block " + ((Block)r));
{code}
which utilize the toString methods of ReplicaUnderConstruction and Block
classes to provide needed info (block id, timestamp), plus replica state which
would help in cases.
The only thing is, if people used to search for "from location: " string for
this message, it won't be there.
But I think this is ok, since this is a debug message and the keyword "Remove
stale replica" is not changed.
Wonder what other people would think. Hi [~andrew.wang], mind comment on my
comment?
Thanks.
> Add more debug info to
> BlockInfoUnderConstruction#setGenerationStampAndVerifyReplicas
> -------------------------------------------------------------------------------------
>
> Key: HDFS-7284
> URL: https://issues.apache.org/jira/browse/HDFS-7284
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.5.1
> Reporter: Hu Liu,
> Assignee: Wei-Chiu Chuang
> Attachments: HDFS-7284.001.patch
>
>
> When I was looking at some replica loss issue, I got the following info from
> log
> {code}
> 2014-10-13 01:54:53,104 INFO BlockStateChange: BLOCK* Removing stale replica
> from location x.x.x.x
> {code}
> I could just know that a replica is removed, but I don't know which block and
> its timestamp. I need to know the id and timestamp of the block from the log
> file.
> So it's better to add more info including block id and timestamp to the code
> snippet
> {code}
> for (ReplicaUnderConstruction r : replicas) {
> if (genStamp != r.getGenerationStamp()) {
> r.getExpectedLocation().removeBlock(this);
> NameNode.blockStateChangeLog.info("BLOCK* Removing stale replica "
> + "from location: " + r.getExpectedLocation());
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
