[
https://issues.apache.org/jira/browse/HDFS-8658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977802#comment-14977802
]
Akira AJISAKA commented on HDFS-8658:
-------------------------------------
After the patch, the log would be more confusing for me. The log is as follows:
{noformat}
WARN: Could not complete <src> retrying... current attempt is 2 out of 5
WARN: Could not complete <src> retrying... current attempt is 4 out of 5
{noformat}
Users might think "1st and 3rd attempts have done correctly, so why 2nd and 4th
attempts are failing?" or "Why 1st and 3rd attempts are not logged (or why they
are debug log)?"
IMO, it would be better to keep it as-is, or print all the attempts in the same
log level.
> Improve retry attempt log in DFSOutputStream#completeFile with current
> attempt number
> --------------------------------------------------------------------------------------
>
> Key: HDFS-8658
> URL: https://issues.apache.org/jira/browse/HDFS-8658
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kanaka Kumar Avvaru
> Assignee: Kanaka Kumar Avvaru
> Priority: Minor
> Attachments: HDFS-8658-00.patch
>
>
> In a scenario when block update was delayed from DN to NN, following client
> log is observed which is confusing that file close failed after two attempts
> but it tried 5 times actually. So, it's better to log the current and
> remaining attempt counts.
> {code}
> 15/06/23 17:05:10 INFO hdfs.DFSClient: Could not complete
> /write2/tst5484._COPYING_ retrying...
> 15/06/23 17:05:16 INFO hdfs.DFSClient: Could not complete
> /write2/tst5484._COPYING_ retrying...
> copyFromLocal: Unable to close file because the last block does not have
> enough number of replicas.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
