[ 
https://issues.apache.org/jira/browse/HDFS-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979426#comment-14979426
 ] 

Zhe Zhang commented on HDFS-9229:
---------------------------------

Thanks Surendra! I agree with you on both points above. I understood shared dir 
wrong, thought it meant shared among different block pools.

So +1 pending a Javadoc on {{nameDirSizeMap}} and changing {{isShared}} to 
{{isShared()}} (assuming you agree).

To be extra safe I will file a follow-on JIRA to bound the time of 
{{sizeOfDirectory}} call (if timeout, just don't update the value).

> Expose size of NameNode directory as a metric
> ---------------------------------------------
>
>                 Key: HDFS-9229
>                 URL: https://issues.apache.org/jira/browse/HDFS-9229
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.7.1
>            Reporter: Zhe Zhang
>            Assignee: Surendra Singh Lilhore
>            Priority: Minor
>         Attachments: HDFS-9229.001.patch, HDFS-9229.002.patch, 
> HDFS-9229.003.patch, HDFS-9229.004.patch, HDFS-9229.005.patch
>
>
> Useful for admins in reserving / managing NN local file system space. Also 
> useful when transferring NN backups.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to