[ 
https://issues.apache.org/jira/browse/HDFS-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981637#comment-14981637
 ] 

James Clampffer commented on HDFS-9340:
---------------------------------------

+1 on the patch, but I think a jira that wires up make test to maven is high 
priority.  If you could implement or help with that step I think I could go the 
rest of the way with the integration tests with minimal support.

"Does the current pom.xml run "make"? I don't see anything in the pom that is 
compiling libhdfspp."
To answer your question Bob it is running make, but how that gets invoked I 
have no idea.  I just looked for the static libraries after the build and they 
all showed up.

"Can you be more concrete on what kinds of documentation can help here? It will 
be great to capture your experience in the wiki for other contributors."
Bob's question about make is pretty much the same thing I'm running into.  I 
know that the build primarily uses maven but things start getting hard to 
follow when that calls ant which calls cmake; at least that's my current 
understanding of the chain of events to build libhdfs++.  In my experience as a 
new contributor it's fairly difficult to follow how mvn install <some flags> 
eventually invokes cmake, and even what the working directories for this 
process are.

I guess what I'd like is a page that says something like:
1a) here's the pom.xml at the root of the project, and a brief summary what the 
most important bits of it do
1b) here are the options you can give at that level to control the build and 
change what sorts of tests get run with different flags etc

2a) when you're using a language like C++ that isn't natural for maven these 
are the steps that are taken to invoke something like cmake
2b) here are some references to the plugins that do most of the work
2c) here's a snippet of code that you could drop in a pom.xml to build some C++ 
project, or here's a a project that should be considered a prototypical example

As someone with a C and C++ and hardware background I don't have the high level 
of familiarity with maven, ant, and the rest of the java ecosystem that I think 
many Hadoop contributors take for granted.  I think the steps above would go a 
long way towards enabling people with with experience similar to mine to become 
productive quickly.  If there isn't much of anything in this area I'd be happy 
to contribute to a wiki that addresses this, I just have to learn it all first.

> libhdfspp fails to compile after HDFS-9207
> ------------------------------------------
>
>                 Key: HDFS-9340
>                 URL: https://issues.apache.org/jira/browse/HDFS-9340
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-9340.HDFS-8707.000.patch
>
>
> After the refactor of HDFS-9207 the {{hadoop-hdfs-client}} module fails to 
> compile as it invokes {{cmake}} against a directory that does not exist. It 
> should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to