[ https://issues.apache.org/jira/browse/HDFS-9343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981668#comment-14981668 ]
Hitesh Shah commented on HDFS-9343: ----------------------------------- Comments: isValid() - is this meant to be a public API? Should this be renamed to isContextValid() as it is only checking the context part? {code} if (callerContext.getSignature() != null && callerContext.getSignature().length <= callerSignatureMaxLen) { {code} - Not checking for zero-length string? - should signature validity check be moved into a function too? > Empty caller context considered invalid > --------------------------------------- > > Key: HDFS-9343 > URL: https://issues.apache.org/jira/browse/HDFS-9343 > Project: Hadoop HDFS > Issue Type: Task > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HDFS-9343.000.patch > > > The caller context with empty context string is considered invalid, and it > should not appear in the audit log. > Meanwhile, too long signature will not be written to audit log. -- This message was sent by Atlassian JIRA (v6.3.4#6332)