[
https://issues.apache.org/jira/browse/HDFS-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992484#comment-14992484
]
Hadoop QA commented on HDFS-9377:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 7s
{color} | {color:blue} docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
20s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} trunk passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 55s
{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs in trunk cannot run
convertXmlToText from findbugs {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s
{color} | {color:green} trunk passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 45s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
37s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 15s
{color} | {color:red} Patch generated 1 new checkstyle issues in
hadoop-hdfs-project/hadoop-hdfs (total was 3, now 4). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
59s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s
{color} | {color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 47s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 51m 58s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_60. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 54m 29s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 22s
{color} | {color:red} Patch generated 58 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 126m 10s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_60 Failed junit tests |
hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure |
| JDK v1.7.0_79 Failed junit tests |
hadoop.hdfs.server.namenode.ha.TestEditLogTailer |
| |
hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForContentSummary |
| JDK v1.7.0_79 Timed out junit tests |
org.apache.hadoop.hdfs.server.blockmanagement.TestPendingReplication |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.7.1 Server=1.7.1
Image:test-patch-base-hadoop-date2015-11-05 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12770695/HDFS-9377.000.patch |
| JIRA Issue | HDFS-9377 |
| Optional Tests | asflicense javac javadoc mvninstall unit findbugs
checkstyle compile |
| uname | Linux 9fd7a6864ca4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-e8bd3ad/precommit/personality/hadoop.sh
|
| git revision | trunk / 46e78a7 |
| Default Java | 1.7.0_79 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_60
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 |
| findbugs | v3.0.0 |
| findbugs |
https://builds.apache.org/job/PreCommit-HDFS-Build/13401/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/13401/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/13401/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/13401/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-HDFS-Build/13401/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt
https://builds.apache.org/job/PreCommit-HDFS-Build/13401/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
|
| JDK v1.7.0_79 Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/13401/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-HDFS-Build/13401/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Max memory used | 228MB |
| Powered by | Apache Yetus http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/13401/console |
This message was automatically generated.
> Fix findbugs warnings in FSDirSnapshotOp
> ----------------------------------------
>
> Key: HDFS-9377
> URL: https://issues.apache.org/jira/browse/HDFS-9377
> Project: Hadoop HDFS
> Issue Type: Task
> Components: namenode
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9377.000.patch
>
>
> I ran findbugs version 3.0.1 and find there is a findbugs warning in
> {{FSDirSnapshotOp}}, brought by [HDFS-9231].
> It's caused by unused variable and the fix is simple.
> {code:title=findbugsXml.xml}
> <BugInstance rank="17" category="STYLE"
> instanceHash="e553cd68a81bb1d8aaf6eba15aa9d322" instanceOccurrenceNum="0"
> priority="2" abbrev="DLS" type="DLS_DEAD_LOCAL_STORE" cweid="563"
> instanceOccurrenceMax="0">
> <ShortMessage>Dead store to local variable</ShortMessage>
> <LongMessage>
> Dead store to sfi in
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
> List, String)
> </LongMessage>
> <Class classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp"
> primary="true">
> <SourceLine start="41"
> classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp"
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java"
> sourcefile="FSDirSnapshotOp.java" end="279">
> <Message>At FSDirSnapshotOp.java:[lines 41-279]</Message>
> </SourceLine>
> <Message>
> In class org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp
> </Message>
> </Class>
> <Method isStatic="true"
> classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp"
> name="getSnapshotFiles" primary="true"
> signature="(Lorg/apache/hadoop/hdfs/server/namenode/FSDirectory;Ljava/util/List;Ljava/lang/String;)Ljava/util/Collection;">
> <SourceLine endBytecode="85" startBytecode="0" start="174"
> classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp"
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java"
> sourcefile="FSDirSnapshotOp.java" end="197"/>
> <Message>
> In method
> org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.getSnapshotFiles(FSDirectory,
> List, String)
> </Message>
> </Method>
> <LocalVariable register="4" name="sfi" pc="16" role="LOCAL_VARIABLE_NAMED">
> <Message>Local variable named sfi</Message>
> </LocalVariable>
> <SourceLine endBytecode="14" startBytecode="14" start="175"
> classname="org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp"
> primary="true"
> sourcepath="org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java"
> sourcefile="FSDirSnapshotOp.java" end="175">
> <Message>At FSDirSnapshotOp.java:[line 175]</Message>
> </SourceLine>
> <Property
> name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.METHOD_RESULT"
> value="true"/>
> <Property name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.LOCAL_NAME"
> value="sfi"/>
> <Property name="edu.umd.cs.findbugs.detect.DeadLocalStoreProperty.NO_LOADS"
> value="true"/>
> </BugInstance>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
