[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993686#comment-14993686 ]
Bob Hansen commented on HDFS-9328: ---------------------------------- I'm sure you don't disagree with the principle in (4), that we should use compiler-specific statements unless necessary. Including a concrete example of where we need to (short circuit reads) even before we get there is, I think, a good thing. I'll accept the clang-format. > Formalize coding standards for libhdfs++ and put them in a README.txt > --------------------------------------------------------------------- > > Key: HDFS-9328 > URL: https://issues.apache.org/jira/browse/HDFS-9328 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Reporter: James Clampffer > Assignee: James Clampffer > Priority: Blocker > Attachments: HDFS-9328.HDFS-8707.000.patch > > > We have 2-3 people working on this project full time and hopefully more > people will start contributing. In order to efficiently scale we need a > single, easy to find, place where developers can check to make sure they are > following the coding standards of this project to both save their time and > save the time of people doing code reviews. > The most practical place to do this seems like a README file in libhdfspp/. > The foundation of the standards is google's C++ guide found here: > https://google-styleguide.googlecode.com/svn/trunk/cppguide.html > Any exceptions to google's standards or additional restrictions need to be > explicitly enumerated so there is one single point of reference for all > libhdfs++ code standards. -- This message was sent by Atlassian JIRA (v6.3.4#6332)