[ 
https://issues.apache.org/jira/browse/HDFS-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei (Eddy) Xu updated HDFS-9267:
--------------------------------
    Attachment: HDFS-9267.03.patch

Hi, [~cmccabe]. 

I updated the patch to provide an {{ReplicaIterator}} class and refactor the 
{{BlockPoolSlice}} to use it. The reason that using {{ReplicaIterator}} instead 
of {{java.util.Iterator}} is that it can {{IOException}} in {{next()}}.

Could you give some feedbacks? Thanks a lot.

> TestDiskError should get stored replicas through FsDatasetTestUtils.
> --------------------------------------------------------------------
>
>                 Key: HDFS-9267
>                 URL: https://issues.apache.org/jira/browse/HDFS-9267
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.7.1
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Minor
>         Attachments: HDFS-9267.00.patch, HDFS-9267.01.patch, 
> HDFS-9267.02.patch, HDFS-9267.03.patch
>
>
> {{TestDiskError#testReplicationError}} scans local directories to verify 
> blocks and metadata files, which leaks the details of {{FsDataset}} 
> implementation. 
> This JIRA will abstract the "scanning" operation to {{FsDatasetTestUtils}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to