[
https://issues.apache.org/jira/browse/HDFS-9245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997416#comment-14997416
]
Mingliang Liu commented on HDFS-9245:
-------------------------------------
Thanks for the review, [~xyao]. I validated locally too and found the findbugs
issue was gone with this patch.
Though there is findbugs warnings in the pre-patch findbugs warnings, the
comment table says:
{quote}
The patch does not introduce any new Findbugs (version 3.0.0) warnings, and
fixes 2 pre-existing warnings.
{quote}
It should be fine?
> Fix findbugs warnings in hdfs-nfs/WriteCtx
> ------------------------------------------
>
> Key: HDFS-9245
> URL: https://issues.apache.org/jira/browse/HDFS-9245
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: nfs
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9245.000.patch, HDFS-9245.001.patch,
> HDFS-9245.002.patch
>
>
> There are findbugs warnings as follows, brought by [HDFS-9092].
> It seems fine to ignore them by write a filter rule in the
> {{findbugsExcludeFile.xml}} file.
> {code:xml}
> <BugInstance rank="17" category="MT_CORRECTNESS"
> instanceHash="592511935f7cb9e5f97ef4c99a6c46c2" instanceOccurrenceNum="0"
> priority="2" abbrev="IS" type="IS2_INCONSISTENT_SYNC" cweid="366"
> instanceOccurrenceMax="0">
> <ShortMessage>Inconsistent synchronization</ShortMessage>
> <LongMessage>
> Inconsistent synchronization of
> org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.offset; locked 75% of time
> </LongMessage>
> <Class classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" primary="true">
> <SourceLine start="40" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx"
> sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java"
> sourcefile="WriteCtx.java" end="314">
> <Message>At WriteCtx.java:[lines 40-314]</Message>
> </SourceLine>
> <Message>In class org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx</Message>
> </Class>
> {code}
> and
> {code:xml}
> <BugInstance rank="17" category="MT_CORRECTNESS"
> instanceHash="4f3daa339eb819220f26c998369b02fe" instanceOccurrenceNum="0"
> priority="2" abbrev="IS" type="IS2_INCONSISTENT_SYNC" cweid="366"
> instanceOccurrenceMax="0">
> <ShortMessage>Inconsistent synchronization</ShortMessage>
> <LongMessage>
> Inconsistent synchronization of
> org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.originalCount; locked 50% of time
> </LongMessage>
> <Class classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" primary="true">
> <SourceLine start="40" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx"
> sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java"
> sourcefile="WriteCtx.java" end="314">
> <Message>At WriteCtx.java:[lines 40-314]</Message>
> </SourceLine>
> <Message>In class org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx</Message>
> </Class>
> <Field isStatic="false" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx"
> name="originalCount" primary="true" signature="I">
> <SourceLine classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx"
> sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java"
> sourcefile="WriteCtx.java">
> <Message>In WriteCtx.java</Message>
> </SourceLine>
> <Message>
> Field org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.originalCount
> </Message>
> </Field>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
