[ 
https://issues.apache.org/jira/browse/HDFS-9410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000709#comment-15000709
 ] 

Xiao Chen commented on HDFS-9410:
---------------------------------

Thanks very much Walter for looking into this! Your comments makes sense, patch 
002 attached reflexes them.
I think this fixes it for the {{TestDFSAdminWithHA}} class, and if we see 
similar issue in other test classes we can file separate JIRAs to fix.

> TestDFSAdminWithHA#tearDown may throw NPE
> -----------------------------------------
>
>                 Key: HDFS-9410
>                 URL: https://issues.apache.org/jira/browse/HDFS-9410
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: HDFS
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>            Priority: Minor
>         Attachments: HDFS-9410.001.patch, HDFS-9410.002.patch
>
>
> If for any reason {{setUpHaCluster}} fails before storing {{System.out}} and 
> {{System.err}} as member variables {{originOut}} and {{originErr}}, then in 
> {{tearDown}} {{System.out}} and {{System.err}} are set to null. This could 
> cause all following tests to fail when calling {{flush}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to