[
https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007274#comment-15007274
]
Bob Hansen commented on HDFS-9328:
----------------------------------
Is there a way to prevent clang-format from changing
{code}
- // Gets values
- std::string GetWithDefault (const std::string & key,
const std::string & defaultValue) const;
- optional<std::string> Get (const std::string & key)
const;
- int64_t GetIntWithDefault (const std::string & key,
int64_t defaultValue) const;
- optional<int64_t> GetInt (const std::string & key)
const;
- double GetDoubleWithDefault (const std::string & key,
double defaultValue) const;
- optional<double> GetDouble (const std::string & key)
const;
- bool GetBoolWithDefault (const std::string & key,
bool defaultValue) const;
- optional<bool> GetBool (const std::string & key)
const;
{code}
into
{code}
+ // Gets values
+ std::string GetWithDefault(const std::string &key,
+ const std::string &defaultValue) const;
+ optional<std::string> Get(const std::string &key) const;
+ int64_t GetIntWithDefault(const std::string &key, int64_t defaultValue)
const;
+ optional<int64_t> GetInt(const std::string &key) const;
+ double GetDoubleWithDefault(const std::string &key,
+ double defaultValue) const;
+ optional<double> GetDouble(const std::string &key) const;
+ bool GetBoolWithDefault(const std::string &key, bool defaultValue) const;
{code}
> Formalize coding standards for libhdfs++
> ----------------------------------------
>
> Key: HDFS-9328
> URL: https://issues.apache.org/jira/browse/HDFS-9328
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: James Clampffer
> Assignee: James Clampffer
> Priority: Blocker
> Fix For: HDFS-8707
>
> Attachments: HDFS-9328.HDFS-8707.000.patch,
> HDFS-9328.HDFS-8707.001.patch, HDFS-9328.HDFS-8707.002.patch,
> HDFS-9328.HDFS-8707.003.patch, HDFS-9328.HDFS-8707.004.patch
>
>
> We have 2-3 people working on this project full time and hopefully more
> people will start contributing. In order to efficiently scale we need a
> single, easy to find, place where developers can check to make sure they are
> following the coding standards of this project to both save their time and
> save the time of people doing code reviews.
> The most practical place to do this seems like a README file in libhdfspp/.
> The foundation of the standards is google's C++ guide found here:
> https://google-styleguide.googlecode.com/svn/trunk/cppguide.html
> Any exceptions to google's standards or additional restrictions need to be
> explicitly enumerated so there is one single point of reference for all
> libhdfs++ code standards.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
