[ https://issues.apache.org/jira/browse/HDFS-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009912#comment-15009912 ]
Chris Nauroth commented on HDFS-9400: ------------------------------------- [~brahmareddy], the patch looks mostly good. One thing I noticed is that prior to HDFS-8979, {{getStoragePolicy}} already had a call to {{checkOpen}}, but {{getStoragePolicies}} did not. The current patch here is removing the {{checkOpen}} call from {{getStoragePolicy}} though. Can you please revise the patch one more time to remove the call from {{getStoragePolicies}} instead? Thank you. > TestRollingUpgradeRollback fails on branch-2. > --------------------------------------------- > > Key: HDFS-9400 > URL: https://issues.apache.org/jira/browse/HDFS-9400 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Chris Nauroth > Assignee: Brahma Reddy Battula > Priority: Blocker > Attachments: HDFS-9400-branch-2.001.patch, HDFS-9400-branch-2.patch > > > During a Jenkins pre-commit run on branch-2 for the HDFS-9394 patch, we > noticed a pre-existing failure in {{TestRollingUpgradeRollback}}. I have > confirmed that this test is failing in branch-2 only. It passes in trunk, > and it passes in branch-2.7. -- This message was sent by Atlassian JIRA (v6.3.4#6332)