[
https://issues.apache.org/jira/browse/HDFS-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032200#comment-15032200
]
Yongjun Zhang commented on HDFS-9474:
-------------------------------------
Hi John,
Thanks for the patch. Two minor:
# Suggest to switch from {{System.println}} to {{LOG.info}}, {{LOG.warn}}, etc.
# For the stack trace printing, suggest to do {{LOG.warn("Error when running "
+ scmd, e)}}
Thanks.
> TestPipelinesFailover would fail if ifconfig is not available
> -------------------------------------------------------------
>
> Key: HDFS-9474
> URL: https://issues.apache.org/jira/browse/HDFS-9474
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Yongjun Zhang
> Assignee: John Zhuge
> Attachments: HDFS-9474.001.patch
>
>
> HDFS-6693 introduced some debug message to debug why when
> TestPipelinesFailover fails.
> HDFS-9438 restricted the debug message to Linux/Mac/Solaris. However, the
> test would fail when printing debug message if "ifconfig" command is not
> available in certain environment.
> This is not quite right. The test should not fail due to the debug message
> printing. We should catch any exception thrown from the code that prints
> debug message, and issue a warning message.
> Suggest to make this change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
