[
https://issues.apache.org/jira/browse/HDFS-8820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032571#comment-15032571
]
Ming Ma commented on HDFS-8820:
-------------------------------
Thanks [~arpitagarwal].
* The last change made to {{RpcEngine}} is from HDFS-7073 in 2.6. It doesn't
seem to cause any issues so far. So maybe Slider is the only implementation
outside HDFS/YARN/MR?
* Alternatively, what if we define {{RpcEngineV2}} and have
{{ProtobufRpcEngine}} implement it? {{RpcEngine}} won't be changed so that it
won't break other implementations. Then deprecate the old interface and remove
it in trunk.
I agree we need to treat compatibility as an important feature for hadoop. But
for this specific case, wonder its impact and if we can somehow use the more
elegant builder approach.
> Simplify enabling NameNode RPC congestion control and FairCallQueue
> -------------------------------------------------------------------
>
> Key: HDFS-8820
> URL: https://issues.apache.org/jira/browse/HDFS-8820
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-8820.01.patch, HDFS-8820.02.patch,
> HDFS-8820.03.patch
>
>
> Enabling RPC Congestion control and FairCallQueue settings can be simplified
> with HDFS-specific configuration keys. Currently the configuration requires
> knowing the exact RPC port number and also whether the service RPC port is
> enabled or not separately. If a separate service RPC endpoint is not defined
> then RPC congestion control must be enabled ([see
> comment|https://issues.apache.org/jira/browse/HDFS-8820?focusedCommentId=14987848&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14987848]
> from [~mingma] below.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
