[
https://issues.apache.org/jira/browse/HDFS-8831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032584#comment-15032584
]
Arpit Agarwal commented on HDFS-8831:
-------------------------------------
Hi [~xyao], thanks for the detailed design note. My comments, mostly around
potential compatibility of classes tagged {{@InterfaceAudience.Public}}.
# DistributedFileSystem.java:2326: We can skip the call to dfs.getEZForPath if
isHDFSEncryptionEnabled is false to avoid extra RPC call when TDE is not
enabled.
# FileSystem.java:2701: Can we define .Trash as a constant somewhere?
# Trash.java:98: Avoid extra RPC for log statement. Can we cache the
currentTrashDir some time earlier?
# TrashPolicy.java:48: I don't think we should mark it as deprecated. While the
TrashPolicyDefault no longer uses the home parameter other implementations may
be passing a different value here in theory.
# TrashPolicy.java:57: Also we should have a default implementation of this
routine else it will be a backward incompatible change (will break existing
implementations of this public interface).
# TrashPolicy.java:83: Need default implementation. It can just throw
UnsupportedOperationException which should be handled by the caller.
# TrashPolicy.java:92: Need default implementation. It can just throw
UnsupportedOperationException which should be handled by the caller.
# TrashPolicy.java:108: We should leave the old method in place to keep the
public interface backwards compatible. Perhaps to be conservative we should
respect the 'home' parameter if one is passed in instead of using
Filesystem#getTrashRoot?
https://github.com/arp7/hadoop/commit/7b3212d2c41cc35cce81eadc68c029e0fc67a429
> Trash Support for deletion in HDFS encryption zone
> --------------------------------------------------
>
> Key: HDFS-8831
> URL: https://issues.apache.org/jira/browse/HDFS-8831
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: HDFS-8831-10152015.pdf, HDFS-8831.00.patch,
> HDFS-8831.01.patch, HDFS-8831.02.patch
>
>
> Currently, "Soft Delete" is only supported if the whole encryption zone is
> deleted. If you delete files whinin the zone with trash feature enabled, you
> will get error similar to the following
> {code}
> rm: Failed to move to trash: hdfs://HW11217.local:9000/z1_1/startnn.sh:
> /z1_1/startnn.sh can't be moved from an encryption zone.
> {code}
> With HDFS-8830, we can support "Soft Delete" by adding the .Trash folder of
> the file being deleted appropriately to the same encryption zone.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
