[
https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032701#comment-15032701
]
Zhe Zhang commented on HDFS-8905:
---------------------------------
Thanks Kai for the update. The new patch looks reasonable with the below nits:
# I realized there's already a {{readBuffer}} in {{DFSInputStream}}. Maybe call
the new method {{readFromBlock}} and {{readSourceBuffer}}?
# Renaming {{len}} to {{realLen}} and {{gotLen}} don't seem necessary.
Could you also explain why HDFS-8901 depends on this change? I browsed
discussions under HDFS-8901 and it seems it is quite independent from this one?
> Refactor DFSInputStream#ReaderStrategy
> --------------------------------------
>
> Key: HDFS-8905
> URL: https://issues.apache.org/jira/browse/HDFS-8905
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-8905-HDFS-7285-v1.patch, HDFS-8905-v2.patch,
> HDFS-8905-v3.patch, HDFS-8905-v4.patch, HDFS-8905-v5.patch
>
>
> DFSInputStream#ReaderStrategy family don't look very good. This refactors a
> little bit to make them make more sense.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
