[ https://issues.apache.org/jira/browse/HDFS-8860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051708#comment-15051708 ]
Hudson commented on HDFS-8860: ------------------------------ SUCCESS: Integrated in Hadoop-trunk-Commit #8952 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8952/]) Revert "HDFS-8860. Remove unused Replica copyOnWrite code (Lei (Eddy) Xu (lei: rev 7f393a6f61f5a34a1de11481ad321c6a941d5d27) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FinalizedReplica.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestDatanodeRestart.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReplicaUnderRecovery.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReplicaInfo.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/DataNodeTestUtils.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReplicaWaitingToBeRecovered.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetTestUtil.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileAppend.java > Remove unused Replica copyOnWrite code > -------------------------------------- > > Key: HDFS-8860 > URL: https://issues.apache.org/jira/browse/HDFS-8860 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 3.0.0, 2.8.0 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Fix For: 2.8.0 > > Attachments: HDFS-8860.0.patch > > > {{ReplicaInfo#unlinkBlock()}} is effectively disabled by the following code, > because {{isUnlinked()}} always returns true. > {code} > if (isUnlinked()) { > return false; > } > {code} > Several test cases, e.g., {{TestFileAppend#testCopyOnWrite}} and > {{TestDatanodeRestart#testRecoverReplicas}} are testing against the unlink > Lets remove the relevant code to eliminate the confusions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)