[ https://issues.apache.org/jira/browse/HDFS-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058026#comment-15058026 ]
Tsz Wo Nicholas Sze commented on HDFS-9371: ------------------------------------------- There are some empty lines added to BlockReportLeaseManager. Patch looks good other than that. +1 > Code cleanup for DatanodeManager > -------------------------------- > > Key: HDFS-9371 > URL: https://issues.apache.org/jira/browse/HDFS-9371 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Jing Zhao > Assignee: Jing Zhao > Attachments: HDFS-9371.000.patch, HDFS-9371.001.patch, > HDFS-9371.002.patch, HDFS-9371.003.patch, HDFS-9371.004.patch > > > Some code cleanup for DatanodeManager. The main changes include: > # make the synchronization of {{datanodeMap}} and > {{datanodesSoftwareVersions}} consistent > # remove unnecessary lock in {{handleHeartbeat}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)