[
https://issues.apache.org/jira/browse/HDFS-9034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063140#comment-15063140
]
Benoy Antony commented on HDFS-9034:
------------------------------------
Reviewed the patch. Sorry for the delay.
Patch looks good. I have following comment:
1. In DatanodeStats.substract, we subtract the storage capacity only if it is
NOT FAILED. But suppose it was good when we added it, then not subtracting will
be a mistake. But if it was bad during add, we should not subtract it. So we
need some additional information to correctly determine whether we should
subtract it or not.
We also need test cases to make sure that these cases are handled correctly.
> "StorageTypeStats" Metric should not count failed storage.
> ----------------------------------------------------------
>
> Key: HDFS-9034
> URL: https://issues.apache.org/jira/browse/HDFS-9034
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Archana T
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-9034.01.patch, HDFS-9034.02.patch,
> HDFS-9034.03.patch, HDFS-9034.04.patch, dfsStorage_NN_UI2.png
>
>
> When we remove one storage type from all the DNs, still NN UI shows entry of
> those storage type --
> Ex:for ARCHIVE
> Steps--
> 1. ARCHIVE Storage type was added for all DNs
> 2. Stop DNs
> 3. Removed ARCHIVE Storages from all DNs
> 4. Restarted DNs
> NN UI shows below --
> DFS Storage Types
> Storage Type Configured Capacity Capacity Used Capacity Remaining
> ARCHIVE 57.18 GB 64 KB (0%) 39.82 GB (69.64%) 64 KB
> 1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
