[
https://issues.apache.org/jira/browse/HDFS-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065068#comment-15065068
]
Mingliang Liu commented on HDFS-9498:
-------------------------------------
Thanks [~anu] for your comment.
Yes we should check the orphan blocks only in start up safe mode.
# The {{BMSafeModeStatus}}, which tracks the start up safe mode only, has three
possible values which are _PENDING_THRESHOLDING_, _EXTENSION_ and _OFF_
respectively. If the NN enters safe mode manually or because of low resource,
the {{FSNamesystem}} will call {{setManualAndResourceLowSafeMode}} while the
{{BlockManagerSafeMode}} stays OFF.
# One corner case is when the NN is in start up safe mode, the operator enters
safe mode manully. The {{BlockManagerSafeMode}} is still in PENDING_THRESHOLD
status. This case we keep tracking the orphan blocks. This is different from
original semantic.
If this does not make sense, we can change it. Is this the case you're
concerned?
> Move code that tracks orphan blocks to BlockManagerSafeMode
> -----------------------------------------------------------
>
> Key: HDFS-9498
> URL: https://issues.apache.org/jira/browse/HDFS-9498
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HDFS-9498.000.patch, HDFS-9498.001.patch,
> HDFS-9498.002.patch, HDFS-9498.003.patch
>
>
> [HDFS-4015] counts and reports orphaned blocks
> {{numberOfBytesInFutureBlocks}} in safe mode. It was implemented in
> {{BlockManager}}. Per discussion in [HDFS-9129] which introduces the
> {{BlockManagerSafeMode}}, we can move code that maintaining orphaned blocks
> to this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
