[
https://issues.apache.org/jira/browse/HDFS-9466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070010#comment-15070010
]
Wei-Chiu Chuang commented on HDFS-9466:
---------------------------------------
Thank you very much for the review and comments!
(1)
AFAIK, the three tests use different fault injectors.
testDataXceiverCleansUpSlotsOnFailure injects a failure at
BlockReaderFactory.requestFileDescriptors(); while
testDataXceiverHandlesRequestShortCircuitShmFailure injects a failure at
DataXceiver.sendShmSuccessResponse, and
testPreReceiptVerificationDfsClientCanDoScr injects a failure at
BlockReaderFactory.requestFileDescriptors().
(2) testPreReceiptVerificationDfsClientCanDoScr should also call
checkNumberOfSegmentsAndSlots to maintain consistency.
(3) Definitely. I was just not sure what would be a reasonable number. Setting
1 second or 10 seconds should be more than sufficient though.
> TestShortCircuitCache#testDataXceiverCleansUpSlotsOnFailure is flaky
> --------------------------------------------------------------------
>
> Key: HDFS-9466
> URL: https://issues.apache.org/jira/browse/HDFS-9466
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: fs, hdfs-client
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Attachments: HDFS-9466.001.patch
>
>
> This test is flaky and fails quite frequently in trunk.
> Error Message
> expected:<1> but was:<2>
> Stacktrace
> {noformat}
> java.lang.AssertionError: expected:<1> but was:<2>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache$17.accept(TestShortCircuitCache.java:636)
> at
> org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry.visit(ShortCircuitRegistry.java:395)
> at
> org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache.checkNumberOfSegmentsAndSlots(TestShortCircuitCache.java:631)
> at
> org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache.testDataXceiverCleansUpSlotsOnFailure(TestShortCircuitCache.java:684)
> {noformat}
> Thanks to [~xiaochen] for identifying the issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
