[ 
https://issues.apache.org/jira/browse/HDFS-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081090#comment-15081090
 ] 

Kai Zheng commented on HDFS-9603:
---------------------------------

Thanks Rui for the nice patch! 
For this util, {{public static RSErasureEncoder createRSEncoder}}, I understand 
it since we only have one workable {{ErasureCoder}} for the moment. I guess we 
can hold on this to wait for the HitchHicker coder to be available so try it 
here. Anyway, it should be {{public static ErasureCoder createErasureEncoder}} 
or the similar and it should return a concrete erasure coder according to 
configuration (not necessarily is the RS one).

A minor, please avoid star import.

> Erasure Coding: Use ErasureCoder to encode/decode a block group
> ---------------------------------------------------------------
>
>                 Key: HDFS-9603
>                 URL: https://issues.apache.org/jira/browse/HDFS-9603
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rui Li
>            Assignee: Rui Li
>         Attachments: HDFS-9603.1.patch
>
>
> According to design, {{ErasureCoder}} is responsible to encode/decode a block 
> group. Currently however, we directly use {{RawErasureCoder}} to do the work, 
> e.g. in {{DFSStripedOutputStream}}. This task attempts to encapsulate 
> {{RawErasureCoder}} to comply with the design.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to