[ https://issues.apache.org/jira/browse/HDFS-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086043#comment-15086043 ]
Mingliang Liu commented on HDFS-9618: ------------------------------------- Thanks for working on this, [~iwasakims]i]. Calling {{neededReplications.size()}} or {{pendingReplications.size()}} seems to have low overhead so the guard can be removed, as [~drankye] proposed. The code that logs which blocks have been scheduled for replication should be kept as we iterate all recovery work and its targets. > Fix mismatch between log level and guard in > BlockManager#computeRecoveryWorkForBlocks > ------------------------------------------------------------------------------------- > > Key: HDFS-9618 > URL: https://issues.apache.org/jira/browse/HDFS-9618 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.8.0 > Reporter: Masatake Iwasaki > Assignee: Masatake Iwasaki > Priority: Minor > Attachments: HDFS-9618.001.patch > > > Debug log message is constructed when {{Logger#isInfoEnabled}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)