[
https://issues.apache.org/jira/browse/HDFS-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088802#comment-15088802
]
Vinayakumar B commented on HDFS-9625:
-------------------------------------
[~Deng FEI],
Thanks for the good find and patch.
Fix looks good.
1. It would be better to add a simple MiniDfsCluster test. mostly in
{{TestSetrepIncreasing.java}}
Nits:
bq. The patch file was not named according to hadoop's naming conventions.
Please see https://wiki.apache.org/hadoop/HowToContribute for instructions
You can name the patch in this format,*HDFS-9625.003.patch*
+1 once addressed.
> set replication for empty file failed when set storage policy
> --------------------------------------------------------------
>
> Key: HDFS-9625
> URL: https://issues.apache.org/jira/browse/HDFS-9625
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.7.1
> Reporter: DENG FEI
> Assignee: DENG FEI
> Attachments: patch.HDFS-9625.002, patch_HDFS-9625.20160107
>
>
> When setReplication, the FSDirectory#updateCount need calculate the
> related storageTypes quota,but will check the file consume the ds quota is
> positive.
> Actually,it's may set replication after create file,like
> JobSplitWriter#createSplitFiles.
> It's also can reproduce on command shell:
> 1. hdfs storagepolicies -setStoragePolicy -path /tmp -policy HOT
> 2. hdfs dfs -touchz /tmp/test
> 3. hdfs dfs -setrep 5 /tmp/test
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
