[
https://issues.apache.org/jira/browse/HDFS-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094186#comment-15094186
]
John Zhuge commented on HDFS-9573:
----------------------------------
Hi [~szetszwo],
Thanks for looking at this jira. hashCode and equals should both use "type"
field or neither of them should use "type" field.
Thanks,
John
> o.a.h.hdfs.protocol.SnapshotDiffReport$DiffReportEntry$hashCode inconsistent
> with equals
> ----------------------------------------------------------------------------------------
>
> Key: HDFS-9573
> URL: https://issues.apache.org/jira/browse/HDFS-9573
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HDFS-9573-001.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> DiffReportEntry.equals() uses field "type", but DiffReportEntry.hashCode()
> doesn't. This breaks the rules on equals and hashCode:
> * if a class overrides equals, it must override hashCode
> * when they are both overridden, equals and hashCode must use the same set of
> fields
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
