[ 
https://issues.apache.org/jira/browse/HDFS-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15099234#comment-15099234
 ] 

Kai Zheng commented on HDFS-9646:
---------------------------------

Thanks Jing for the update.

Do you think it's good to address my minor comments and suggestions in a 
separate issue if not good here?

bq. Question: do we need new test codes to expose the issue and ensure the 
issue is fixed?
Could you help clarify this question? Sorry if I missed something.

bq. I think the randomized generateDeadDnIndices() can test that.
Hi Walter, I'm not sure about this. If so, why this issue wasn't exposed until 
this is reported?

As this may cover the work of HDFS-9585, as [~andrew.wang] commented there, if 
there is no new test codes to expose the issue and verify the fix, we might 
probably need to add. Sure I probably missed some change, and kindly help point 
it out if so. Thanks.

> ErasureCodingWorker may fail when recovering data blocks with length less 
> than the first internal block
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9646
>                 URL: https://issues.apache.org/jira/browse/HDFS-9646
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>    Affects Versions: 3.0.0
>            Reporter: Takuya Fukudome
>            Assignee: Jing Zhao
>            Priority: Critical
>         Attachments: HDFS-9646.000.patch, HDFS-9646.001.patch, 
> test-reconstruct-stripe-file.patch
>
>
> This is reported by [~tfukudom]: ErasureCodingWorker may fail with the 
> following exception when recovering a non-full internal block.
> {code}
> 2016-01-06 11:14:44,740 WARN  datanode.DataNode 
> (ErasureCodingWorker.java:run(467)) - Failed to recover striped block: 
> BP-987302662-172.29.4.13-1450757377698:blk_-92233720368
> 54322288_29751
> java.io.IOException: Transfer failed for all targets.
>         at 
> org.apache.hadoop.hdfs.server.datanode.erasurecode.ErasureCodingWorker$ReconstructAndTransferBlock.run(ErasureCodingWorker.java:455)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to