[ https://issues.apache.org/jira/browse/HDFS-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110531#comment-15110531 ]
Kai Zheng commented on HDFS-9542: --------------------------------- Yeah, nice refactoring. Just wonder if it's a good idea to rename: {{generationStampV1}} => {{legacyGenerationStamp}}; {{generationStampV2}} => {{generationStamp}}, similar for other variables, as we have {{legacy block}} and {{block}}. > Move BlockIdManager from FSNamesystem to BlockManager > ----------------------------------------------------- > > Key: HDFS-9542 > URL: https://issues.apache.org/jira/browse/HDFS-9542 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Jing Zhao > Assignee: Jing Zhao > Attachments: HDFS-9542.000.patch, HDFS-9542.001.patch > > > Semantically BlockIdManager should be a field in BlockManager instead of > FSNamesystem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)