[ 
https://issues.apache.org/jira/browse/HDFS-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110720#comment-15110720
 ] 

Bob Hansen commented on HDFS-9643:
----------------------------------

In {{ReaderGroup::GetLiveReaders()}}, you need to trim the readers_ member once 
you're done with {{remove_if}}.  {{remove_if}} only shuffles the live elements 
forward and returns the new end; you need a subsequent {{readers_.erase(newEnd, 
readers_.end());}}

What does the comment "no-op to keep method PV qualified in parent" mean?

I don't see an implementation of {{DataNodeConnection::Cancel()}}.  Did I miss 
something?



> libhdfs++: Support async cancellation of read operations
> --------------------------------------------------------
>
>                 Key: HDFS-9643
>                 URL: https://issues.apache.org/jira/browse/HDFS-9643
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>         Attachments: HDFS-9643.HDFS-8707.000.patch, 
> HDFS-9643.HDFS-8707.001.patch, HDFS-9643.HDFS-8707.002.patch
>
>
> It should be possible for any thread to cancel operations in progress on a 
> FileHandle.  Any ephemeral objects created by the FileHandle should free 
> resources as quickly as possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to