[
https://issues.apache.org/jira/browse/HDFS-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HDFS-9708:
--------------------------------
Attachment: HDFS-9708.001.patch
Thanks [~ste...@apache.org] for your suggestion. In v0 patch, I find the
{{Configuration#getTrimmedStringCollection()}} is tested and assume that's
covered.
As there is logic for _default_ and _top_ audit loggers in {{FSNamesystem}},
the v1 patch adds unit test for audit loggers initialization.
> FSNamesystem.initAuditLoggers() doesn't trim classnames
> -------------------------------------------------------
>
> Key: HDFS-9708
> URL: https://issues.apache.org/jira/browse/HDFS-9708
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: Mingliang Liu
> Priority: Minor
> Attachments: HDFS-9708.000.patch, HDFS-9708.001.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> The {{FSNamesystem.initAuditLoggers()}} method reads a list of audit loggers
> from a call to {{ conf.getStringCollection(DFS_NAMENODE_AUDIT_LOGGERS_KEY);}}
> What it doesn't do is trim each entry -so if there's a space or newline in the
> list, the classname is invalid and won't load, so HDFS wont come out to play.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
