[ https://issues.apache.org/jira/browse/HDFS-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001238#comment-13001238 ]
Suresh Srinivas commented on HDFS-1677: --------------------------------------- Test-patch: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.8) warnings. [exec] [exec] -1 release audit. The applied patch generated 100 release audit warnings (more than the trunk's current 1 warnings). [exec] [exec] +1 system test framework. The patch passed system test framework compile. Release audit is bogus. I find it actually pretty disturbing that this refactor didn't touch any tests; this indicates no coverage for these classes. Because this is just a renaming and commenting patch. > HDF federation: Fix TestFsck and TestListCorruptFileBlocks failures > -------------------------------------------------------------------- > > Key: HDFS-1677 > URL: https://issues.apache.org/jira/browse/HDFS-1677 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test > Affects Versions: Federation Branch > Reporter: Tanping Wang > Assignee: Tanping Wang > Priority: Minor > Fix For: Federation Branch > > Attachments: HDFS-1677.patch > > > These tests are failing due to null pointer exception. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira