[
https://issues.apache.org/jira/browse/HDFS-9260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124467#comment-15124467
]
Colin Patrick McCabe commented on HDFS-9260:
--------------------------------------------
Thanks, [~sfriberg].
{code}
4194 if
(!storage.treeSetCompact(storageInfoDefragmentTimeout)) {
4195 // Compaction timed out, reset iterator to continue with
4196 // the same storage next iteration.
4197 i += 2;
4198 }
4199 LOG.info("StorageInfo TreeSet defragmented {} : {}",
4200 storage.getStorageID(),
storage.treeSetFillRatio());
4201 }
{code}
Hmm. The comment says "reset iterator." Is this intended to be subtracing 2
from i, rather than adding? Also, shouldn't we log a message when compaction
times out? Right now we log the success message whether or not it actually
succeeded, right?
> Improve performance and GC friendliness of startup and FBRs
> -----------------------------------------------------------
>
> Key: HDFS-9260
> URL: https://issues.apache.org/jira/browse/HDFS-9260
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, namenode, performance
> Affects Versions: 2.7.1
> Reporter: Staffan Friberg
> Assignee: Staffan Friberg
> Attachments: FBR processing.png, HDFS Block and Replica Management
> 20151013.pdf, HDFS-7435.001.patch, HDFS-7435.002.patch, HDFS-7435.003.patch,
> HDFS-7435.004.patch, HDFS-7435.005.patch, HDFS-7435.006.patch,
> HDFS-7435.007.patch, HDFS-9260.008.patch, HDFS-9260.009.patch,
> HDFS-9260.010.patch, HDFS-9260.011.patch, HDFS-9260.012.patch,
> HDFS-9260.013.patch, HDFS-9260.014.patch, HDFS-9260.015.patch,
> HDFS-9260.016.patch, HDFS-9260.017.patch, HDFSBenchmarks.zip,
> HDFSBenchmarks2.zip
>
>
> This patch changes the datastructures used for BlockInfos and Replicas to
> keep them sorted. This allows faster and more GC friendly handling of full
> block reports.
> Would like to hear peoples feedback on this change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
