[ 
https://issues.apache.org/jira/browse/HDFS-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132256#comment-15132256
 ] 

Vinayakumar B commented on HDFS-7708:
-------------------------------------

bq. Mostly balancer will be exited automatically after re-balancing operation 
and may not always execute the stop script. In that case what is your opinion 
in providing an additional shutdown hooks especially for the balancer daemon to 
cleanup/remove the balancer pid file ?
Since the balancer comes with stop-script, why not use it.
There balancer could be started as foreground process too {{hdfs balancer}}, if 
shutdownhook added, that time also it tries to delete it, no harm though.
Still, since the pid file is created by script, I tend towards handling that in 
script itself.

> Balancer should delete its pid file when it completes rebalance
> ---------------------------------------------------------------
>
>                 Key: HDFS-7708
>                 URL: https://issues.apache.org/jira/browse/HDFS-7708
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: balancer & mover
>    Affects Versions: 2.6.0
>            Reporter: Akira AJISAKA
>            Assignee: Rakesh R
>         Attachments: HDFS-7708-002.patch, HDFS-7708.patch
>
>
> When balancer completes rebalance and exits, it does not delete its pid file. 
> Starting balancer again, then "kill -0 pid" to confirm the balancer process 
> is not running.
> The problem is: If another process is running as the same pid as `cat 
> pidfile`, balancer fails to start with following message:
> {code}
>   balancer is running as process 3443. Stop it first.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to