[ 
https://issues.apache.org/jira/browse/HDFS-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001758#comment-13001758
 ] 

Jitendra Nath Pandey commented on HDFS-1689:
--------------------------------------------


-1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 system test framework.  The patch failed system test framework compile.

Example of  system test framework failures:
  ..src/test/system/aop/org/apache/hadoop/hdfs/HDFSPolicyProviderAspect.aj:24 
[error] The import org.apache.hadoop.test.system cannot be resolved
     [iajc] import org.apache.hadoop.test.system.DaemonProtocol;

   None of those errors seem to be related to this patch.

> Hdfs Federation: Configuration for namenodes
> --------------------------------------------
>
>                 Key: HDFS-1689
>                 URL: https://issues.apache.org/jira/browse/HDFS-1689
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: Federation Branch
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: Federation Branch
>
>         Attachments: HDFS-1689.1.patch, HDFS-1689.2.patch
>
>
> We need ability to specify some configuration parameters which are namenode 
> specific.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to