[
https://issues.apache.org/jira/browse/HDFS-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140132#comment-15140132
]
Karthik Kambatla commented on HDFS-9637:
----------------------------------------
Reviewing the tests here, following up from the feature added in Common.
The patch looks pretty good. Nice tests and very happy to see the detailed
documentation. My only comment would be: use @Before and @After methods to do
the setup and cleanup, that way we don't have to do try-finally blocks.
> Add test for HADOOP-12702 and HADOOP-12759
> ------------------------------------------
>
> Key: HDFS-9637
> URL: https://issues.apache.org/jira/browse/HDFS-9637
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 2.7.1
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Attachments: HDFS-9637.001.patch, HDFS-9637.002.patch,
> HDFS-9637.003.patch, HDFS-9637.004.patch
>
>
> Per discussion on the dev list, the tests for the new FileSystemSink class
> should be added to the HDFS project to avoid creating a dependency for the
> common project on the HDFS project.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
