[ https://issues.apache.org/jira/browse/HDFS-9799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145345#comment-15145345 ]
Andrew Wang commented on HDFS-9799: ----------------------------------- >From an API point of view, these two methods should be similar. Another flaw >with getTrashRoots is that an exception for any single trash root fails the >entire call. There's no ability to do a partial return, which IMO is better >since it gives the caller flexibility. Regarding error handling, pre HDFS-8831 it looks like TrashPolicyDefault would just catch and log exceptions. So the exception itself isn't being used for much. > Reimplement getCurrentTrashDir to remove incompatibility > -------------------------------------------------------- > > Key: HDFS-9799 > URL: https://issues.apache.org/jira/browse/HDFS-9799 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.8.0 > Reporter: Zhe Zhang > Assignee: Zhe Zhang > Priority: Blocker > Attachments: HDFS-9799.00.patch, HDFS-9799.01.patch, > HDFS-9799.02.patch > > > HDFS-8831 changed the signature of {{TrashPolicy#getCurrentTrashDir}} by > adding an IOException. This breaks other applications using this public API. > This JIRA aims to reimplement the logic to safely handle the IOException > within HDFS. -- This message was sent by Atlassian JIRA (v6.3.4#6332)