[ https://issues.apache.org/jira/browse/HDFS-8923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151428#comment-15151428 ]
Tsz Wo Nicholas Sze commented on HDFS-8923: ------------------------------------------- {code} + "\n\t[-include [-f <hosts-file> | <comma-separated list of hosts>]]" + "\tIncludes only the specified datanodes." + + "\n\t[-source [-f <hosts-file> | <comma-separated list of hosts>]]" + + "\tIncludes only the specified datanodes when picking source nodes." {code} Let's don't use "Includes" since it may be confused with -include. How about "Pick only the specified datanodes as source nodes"? > Add -source flag to balancer usage message > ------------------------------------------ > > Key: HDFS-8923 > URL: https://issues.apache.org/jira/browse/HDFS-8923 > Project: Hadoop HDFS > Issue Type: Bug > Components: balancer & mover > Reporter: Chris Trezzo > Assignee: Chris Trezzo > Priority: Trivial > Attachments: HDFS-8923-trunk-v1.patch, HDFS-8923-trunk-v2.patch, > HDFS-8923-trunk-v3.patch > > > HDFS-8826 added a -source flag to the balancer, but the usage message still > needs to be updated. See current usage message in trunk: > {code} > private static final String USAGE = "Usage: hdfs balancer" > + "\n\t[-policy <policy>]\tthe balancing policy: " > + BalancingPolicy.Node.INSTANCE.getName() + " or " > + BalancingPolicy.Pool.INSTANCE.getName() > + "\n\t[-threshold <threshold>]\tPercentage of disk capacity" > + "\n\t[-exclude [-f <hosts-file> | <comma-separated list of hosts>]]" > + "\tExcludes the specified datanodes." > + "\n\t[-include [-f <hosts-file> | <comma-separated list of hosts>]]" > + "\tIncludes only the specified datanodes." > + "\n\t[-idleiterations <idleiterations>]" > + "\tNumber of consecutive idle iterations (-1 for Infinite) before " > + "exit." > + "\n\t[-runDuringUpgrade]" > + "\tWhether to run the balancer during an ongoing HDFS upgrade." > + "This is usually not desired since it will not affect used space " > + "on over-utilized machines."; > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)