[ https://issues.apache.org/jira/browse/HDFS-9805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153064#comment-15153064 ]
Gary Helmling commented on HDFS-9805: ------------------------------------- The checkstyle warning is on the {{DataXceiver::writeBlock()}} method being 236 lines long, greater than max allowed of 150. This patch adds a single line to {{writeBlock()}}, which I think triggered the warning. But I don't think it makes sense to refactor the method as part of this issue. For java 8, the following tests failed or timed out: {noformat} Failed tests: TestDatanodeRegistration.testForcedRegistration:382 null TestHAAppend.testMultipleAppendsDuringCatchupTailing:125 inode should complete in ~60000 ms. Expected: is <true> but: was <false> TestStandbyCheckpoints.testCheckpointCancellationDuringUpload:347 expected:<0> but was:<108> Tests in error: TestDelegationTokenForProxyUser.testWebHdfsDoAs:161 ? test timed out after 50... TestDirectoryScanner.testThrottling:584->createFile:108->Object.wait:502->Object.wait:-2 ? TestEditLogTailer.testNN1TriggersLogRolls:115->testStandbyTriggersLogRolls:147->waitForLogRollInSharedDir:168 ? Timeout TestSecureNNWithQJM.testSecureMode:167->doNNWithQJMTest:187->restartNameNode:205->Object.wait:502->Object.wait:-2 ? TestSecureNNWithQJM.testSecondaryNameNodeHttpAddressNotNeeded:173->doNNWithQJMTest:193->restartNameNode:205 ? EditLogInput {noformat} All of these pass for me locally. For java 7, the following tests failed or timed out: {noformat} Failed tests: TestDataNodeVolumeFailure.testUnderReplicationAfterVolFailure:412 There is no under replicated block after volume failure TestBlockReplacement.testDeletedBlockWhenAddBlockIsInEdit:436 The block should be only on 1 datanode expected:<1> but was:<2> TestNameNodeMetadataConsistency.testGenerationStampInFuture:113 expected:<17> but was:<0> TestHAAppend.testMultipleAppendsDuringCatchupTailing:125 inode should complete in ~60000 ms. Expected: is <true> but: was <false> Tests in error: TestRollingFileSystemSinkWithSecureHdfs.testMissingPropertiesWithSecureHDFS:145->createDirectoriesSecurely:191 ? IO TestDataNodeHotSwapVolumes.testRemoveVolumeBeingWritten:609->testRemoveVolumeBeingWrittenForDatanode:686 ? Timeout TestDataNodeMultipleRegistrations.testClusterIdMismatchAtStartupWithHA:253 ? ... TestNNHandlesCombinedBlockReport>BlockReportTestBase.testOneReplicaRbwReportArrivesAfterBlockCompleted:630 ? TestDirectoryScanner.testThrottling:584->createFile:108->Object.wait:503->Object.wait:-2 ? TestSecureNameNode.testName:65 ? IO Failed on local exception: java.io.IOExcep... TestFileTruncate.testTruncateWithDataNodesRestart:704 ? Timeout Timed out wait... TestEncryptionZones.testStartFileRetry:1067 ? test timed out after 120000 mil... {noformat} All of these pass locally for me with java 7 as well. > TCP_NODELAY not set before SASL handshake in data transfer pipeline > ------------------------------------------------------------------- > > Key: HDFS-9805 > URL: https://issues.apache.org/jira/browse/HDFS-9805 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Reporter: Gary Helmling > Assignee: Gary Helmling > Attachments: HDFS-9805.001.patch > > > There are a few places in the DN -> DN block transfer pipeline where > TCP_NODELAY is not set before doing a SASL handshake: > * in {{DataNode.DataTransfer::run()}} > * in {{DataXceiver::replaceBlock()}} > * in {{DataXceiver::writeBlock()}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)