[ https://issues.apache.org/jira/browse/HDFS-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153672#comment-15153672 ]
Rakesh R commented on HDFS-9829: -------------------------------- Thanks [~jingzhao], attached another patch addressing the comment. > Erasure Coding: Improve few exception handling logic of ErasureCodingWorker > --------------------------------------------------------------------------- > > Key: HDFS-9829 > URL: https://issues.apache.org/jira/browse/HDFS-9829 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding > Reporter: Rakesh R > Assignee: Rakesh R > Priority: Minor > Attachments: HDFS-9829-001.patch, HDFS-9829-002.patch > > > # Cancel remaining reads on InterruptedException. > {code} > } catch (InterruptedException e) { > LOG.info("Read data interrupted.", e); > break; > } > {code} > # Shouldn't fail recontruction due to an IOException errors while reporting > corrupt blocks. > {code} > } finally { > // report corrupted blocks to NN > reportCorruptedBlocks(corruptionMap); > } > {code} > # {{ECW#closeBlockReader()}} function can be simplified using > {{IOUtils.closeStream(closable)}} > # Also, use {} instead of string concatenation in logger. > {code} > LOG.debug("Using striped reads; pool threads=" + num); > //... > LOG.warn("Found Checksum error for " + reader.block + " from " > + reader.source + " at " + e.getPos()); > //... > LOG.debug("Using striped block reconstruction; pool threads=" + num); > //.. > LOG.warn("Failed to reconstruct striped block: " + blockGroup, e); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)