[
https://issues.apache.org/jira/browse/HDFS-9671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157562#comment-15157562
]
Arpit Agarwal commented on HDFS-9671:
-------------------------------------
Thanks for the updated patch [~anu].
# {{shutdownExecutor}} can release the lock before calling
{{awaitTermination}}. Else we could block an incoming RPC for up to 60 seconds.
I think once {{ExecutorService#shutdown}} is called no new submitted tasks will
be accepted so it should be fine to call {{awaitTermination}} without the lock.
Okay to fix in a subsequent Jira.
# bq. We do exactly that in createPlan(NodePlan plan)
Actually what I meant was for DiskBalancer should not have references to
FsVolumeSpi at any point and only deal with storage IDs. We can defer this also
to a future Jira.
+1 I will commit this today.
> DiskBalancer : SubmitPlan implementation
> -----------------------------------------
>
> Key: HDFS-9671
> URL: https://issues.apache.org/jira/browse/HDFS-9671
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: HDFS-1312
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Attachments: HDFS-9671-HDFS-1312.001.patch,
> HDFS-9671-HDFS-1312.002.patch, HDFS-9671-HDFS-1312.003.patch,
> HDFS-9671-HDFS-1312.004.patch, HDFS-9671-HDFS-1312.005.patch,
> HDFS-9671-HDFS-1312.006.patch
>
>
> Datanode side code for submit plan for diskbalancer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
