[
https://issues.apache.org/jira/browse/HDFS-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003247#comment-13003247
]
Todd Lipcon commented on HDFS-1611:
-----------------------------------
For the log message for ClientDatanodeProtocol, I think it's better to change
the log to Debug level, rather than change the guard. It's not that useful of a
log message to be set at INFO level.
> Some logical issues need to address.
> ------------------------------------
>
> Key: HDFS-1611
> URL: https://issues.apache.org/jira/browse/HDFS-1611
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client, name-node
> Affects Versions: 0.20.1, 0.20.2
> Reporter: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HDFS-1611.patch
>
>
> Title: Some code level logical issues.
> Description:
> 1. DFSClient:
> Consider the below case, if we enable only info, then below log will never
> be logged.
> if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
> ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
> }
> 2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
>
> catch (NotCompliantMBeanException e) {
> e.printStackTrace();
> }
> We can avoid using stackTace(). Better to add log message.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
