[
https://issues.apache.org/jira/browse/HDFS-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198027#comment-15198027
]
Xiao Chen commented on HDFS-9405:
---------------------------------
Thanks for the review Andrew! All comments are addressed in patch 8.
I think it's a great idea to use {{SingleThreadExecutor}} and
{{ThreadFactoryBuilder}} - it's more convenient and standardized than the
current way of hadoop {{Daemon}}.
I thought about {{waitFor}} in the test before, but since we implicitly waits
for minicluster to come up, I didn't added it. Agreed adding it makes little
harm, while strengthens the test.
BTW, haven't really think about 'retires' much, good catch. :)
> When starting a file, NameNode should generate EDEK in a separate thread
> ------------------------------------------------------------------------
>
> Key: HDFS-9405
> URL: https://issues.apache.org/jira/browse/HDFS-9405
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: encryption, namenode
> Affects Versions: 2.7.1
> Reporter: Zhe Zhang
> Assignee: Xiao Chen
> Attachments: HDFS-9405.01.patch, HDFS-9405.02.patch,
> HDFS-9405.03.patch, HDFS-9405.04.patch, HDFS-9405.05.patch,
> HDFS-9405.06.patch, HDFS-9405.07.patch, HDFS-9405.08.patch
>
>
> {{generateEncryptedDataEncryptionKey}} involves a non-trivial I/O operation
> to the key provider, which could be slow or cause timeout. It should be done
> as a separate thread so as to return a proper error message to the RPC caller.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
