[ 
https://issues.apache.org/jira/browse/HDFS-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200058#comment-15200058
 ] 

John Zhuge commented on HDFS-9885:
----------------------------------

Thanks for the patch. Minor comments:
* Replace "Distcp" and "distcp" with "DistCp" in the properties file
* Is it possible to remove "_" in the file name 
"CopyMapper_Counter.properties"? Check out existing file names:
{noformat}
resources/org/apache/hadoop/mapreduce/FileSystemCounter.properties
resources/org/apache/hadoop/mapreduce/JobCounter.properties
resources/org/apache/hadoop/mapreduce/lib/input/FileInputFormatCounter.properties
resources/org/apache/hadoop/mapreduce/lib/output/FileOutputFormatCounter.properties
resources/org/apache/hadoop/mapreduce/TaskCounter.properties
{noformat}

> In distcp cmd ouput, Display name should be given for 
> org.apache.hadoop.tools.mapred.CopyMapper$Counter.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9885
>                 URL: https://issues.apache.org/jira/browse/HDFS-9885
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: distcp
>    Affects Versions: 2.7.1
>            Reporter: Archana T
>            Assignee: Surendra Singh Lilhore
>            Priority: Minor
>         Attachments: HDFS-9885.001.patch
>
>
> In distcp cmd output,
> hadoop distcp hdfs://NN1:port/file1 hdfs://NN2:port/file2
> 16/02/29 07:05:55 INFO tools.DistCp: DistCp job-id: job_1456729398560_0002
> 16/02/29 07:05:55 INFO mapreduce.Job: Running job: job_1456729398560_0002
> 16/02/29 07:06:01 INFO mapreduce.Job: Job job_1456729398560_0002 running in 
> uber mode : false
> 16/02/29 07:06:01 INFO mapreduce.Job: map 0% reduce 0%
> 16/02/29 07:06:06 INFO mapreduce.Job: map 100% reduce 0%
> 16/02/29 07:06:07 INFO mapreduce.Job: Job job_1456729398560_0002 completed 
> successfully
> ...
> ...
> File Input Format Counters
> Bytes Read=212
> File Output Format Counters
> Bytes Written=0{color:red} 
> org.apache.hadoop.tools.mapred.CopyMapper$Counter
> {color}
> BANDWIDTH_IN_BYTES=12418
> BYTESCOPIED=12418
> BYTESEXPECTED=12418
> COPY=1
> Expected:
> Display Name can be given instead of 
> {color:red}"org.apache.hadoop.tools.mapred.CopyMapper$Counter"{color}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to