[
https://issues.apache.org/jira/browse/HDFS-9847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204613#comment-15204613
]
Arpit Agarwal commented on HDFS-9847:
-------------------------------------
Thanks [~linyiqun]. I am +1 for the latest patch with a minor issue - the
following line should also include the name of the configuration setting.
{code}
1660 throw new HadoopIllegalArgumentException("Loss of precision
converting "
1661 + timeStr + vUnit.suffix() + " to " + unit);
{code}
I will hold off committing for now in case [~chris.douglas] or
[~ste...@apache.org] have comments. Steve - I think the only open question was
whether to add week/year suffixes. I don't have an opinion either way.
> HDFS configuration without time unit name should accept friendly time units
> ---------------------------------------------------------------------------
>
> Key: HDFS-9847
> URL: https://issues.apache.org/jira/browse/HDFS-9847
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.7.1
> Reporter: Lin Yiqun
> Assignee: Lin Yiqun
> Attachments: HDFS-9847.001.patch, HDFS-9847.002.patch,
> HDFS-9847.003.patch, HDFS-9847.004.patch, HDFS-9847.005.patch,
> HDFS-9847.006.patch, timeduration-w-y.patch
>
>
> In HDFS-9821, it talks about the issue of leting existing keys use friendly
> units e.g. 60s, 5m, 1d, 6w etc. But there are som configuration key names
> contain time unit name, like {{dfs.blockreport.intervalMsec}}, so we can make
> some other configurations which without time unit name to accept friendly
> time units. The time unit {{seconds}} is frequently used in hdfs. We can
> updating this configurations first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
