[
https://issues.apache.org/jira/browse/HDFS-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Zhuge updated HDFS-9573:
-----------------------------
Resolution: Won't Fix
Status: Resolved (was: Patch Available)
It is recommended for hashCode and equals to use the same set of fields,
however it is not mandatory. The impact is only a potential performance problem
of hash table.
> SnapshotDiffReport$DiffReportEntry$hashCode should use type field
> -----------------------------------------------------------------
>
> Key: HDFS-9573
> URL: https://issues.apache.org/jira/browse/HDFS-9573
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HDFS-9573-001.patch, HDFS-9573-002.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> DiffReportEntry.equals() uses field "type", but DiffReportEntry.hashCode()
> doesn't. This breaks the rules on equals and hashCode:
> * if a class overrides equals, it must override hashCode
> * when they are both overridden, equals and hashCode must use the same set of
> fields
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
