[
https://issues.apache.org/jira/browse/HDFS-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221191#comment-15221191
]
Chris Nauroth commented on HDFS-10238:
--------------------------------------
Hi [~anu]. This is looking good. I just have a few comments at this point.
# There are a couple of places where {{InterruptedException}} is included as
part of a multi-catch. Handling an {{InterruptedException}} is always a unique
case, so I think it will need its own {{catch}} clause. As per Java best
practice, you'll need to re-raise the interrupt flag by calling
{{Thread.currentThread().interrupt()}} in addition to whatever specific error
handling/reporting is needed.
# I'm pretty sure usage of JUnit {{ExpectedException}} will halt execution of
the test after the exception is thrown. For example, in
{{TestContainerPersistence#testOverWrite}}, you use an {{ExpectedException}} to
check that the next call throws an exception, but then you have code after it
that repeats the same call with the overwrite flag to make sure that works
fine. I'm pretty sure that code never executes, because the earlier call does
throw an exception out of the test method. You might need to refactor this
additional code using the overwrite flag into its own separate test method to
achieve the code coverage you want.
> Ozone : Add chunk persistance
> -----------------------------
>
> Key: HDFS-10238
> URL: https://issues.apache.org/jira/browse/HDFS-10238
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-7240
>
> Attachments: HDFS-10238-HDFS-7240.001.patch
>
>
> Add support for chunks in containers for ozone.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
