[ https://issues.apache.org/jira/browse/HDFS-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258671#comment-15258671 ]
Anu Engineer commented on HDFS-9545: ------------------------------------ Hi [~eddyxu] Thanks for your comments. Please see my responses to your comments. bq. Should we consider cluster URI “file://" as illegal for DiskBalancer? Since there is no DN? You are absolutely right, but this allows me to load a snapshot of a node -- and see how diskBalancer is working in case of issues. This is more like a bug reporting tool and I envisage me being the principal user of this feature. Mainly to debug issues when reported by users. bq. If we just let diskBalancerLogs = path, in this way, it might be easier for admins to write scripts against DiskBalancer as they can fully control the output dirs. Good catch, Thank you for bringing this up. I would hate it if a tool did this to me :( bq. A general question regarding generating logs dir, are the commands usually issued against the cluster or just one specific DN? If it only works for one specific DN, we might want to put DN hostname or IP into diskBalancerLogs path We are right now doing it against a specific datanode, in future some commands might work against the cluster. We write LOGDIR/*nodename*.before.json and LOGDIR/*nodename*.plan.json right now I will fix all the other issues mentioned by you and upload a new patch. > DiskBalancer : Add Plan Command > ------------------------------- > > Key: HDFS-9545 > URL: https://issues.apache.org/jira/browse/HDFS-9545 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode > Reporter: Anu Engineer > Assignee: Anu Engineer > Attachments: HDFS-9545-HDFS-1312.001.patch > > > Allows user to create a Plan and persist it. This is useful if the users want > to evaluate the actions of disk balancer before running the balancing job -- This message was sent by Atlassian JIRA (v6.3.4#6332)