[ 
https://issues.apache.org/jira/browse/HDFS-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264747#comment-15264747
 ] 

Mingliang Liu commented on HDFS-10347:
--------------------------------------

+1 (non-binding) as the patch is simple and clear.

My minor concern is we're dumping state change log while holding the lock, 
which is not ideal.

> Namenode report bad block method doesn't log the bad block or datanode.
> -----------------------------------------------------------------------
>
>                 Key: HDFS-10347
>                 URL: https://issues.apache.org/jira/browse/HDFS-10347
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.7.0
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>            Priority: Minor
>         Attachments: HDFS-10347.patch
>
>
> Currently the method {{FSNamesystem#reportBadBlocks}} doesn't log any 
> information regarding the bad block id or the datanode on which corrupt block 
> is detected.
> It would be helpful to log that information to debug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to